search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Remove unnecessary manageJobsWithoutQueueName field on deployment webhook. #3557

Closed mbobrovskyi closed 1 week ago

mbobrovskyi commented 1 week ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Remove unnecessary manageJobsWithoutQueueName field on deployment webhook.

Which issue(s) this PR fixes:

Prepare for #3555

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 723e4c66bd6de03305b93a72187e84d415893f40
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67379eceb0c692000876226a
k8s-ci-robot commented 1 week ago

LGTM label has been added.

Git tree hash: 9c09faa436c5f356e663136cd0cc6535c18c3acd

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/controller/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/controller/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mbobrovskyi commented 1 week ago

/cherry-pick release-0.9

k8s-infra-cherrypick-robot commented 1 week ago

@mbobrovskyi: new pull request created: #3578

In response to [this](https://github.com/kubernetes-sigs/kueue/pull/3557#issuecomment-2483005817): >/cherry-pick release-0.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.