kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.49k stars 267 forks source link

Added info to 0.9.1 about Rank Ordering being deferred to the next release #3586

Closed mwysokin closed 1 week ago

mwysokin commented 1 week ago

What type of PR is this?

/kind documentation

What this PR does / why we need it:

We previously suggested during KubeCon and on other occasions that Rank Ordering in TAS would be part of Kueue release 0.9.1. Since the users are highly anticipating this feature and release 0.9.1 was released without it we want to make sure that we didn't mislead anyone and so that people don't waste their time testing feature which was not part of the release. That's why I'd like to request adding this note section to the 0.9.1 release notes to make things very clear.

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 1 week ago

Hi @mwysokin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 8ab504553602863f584f63430ea9ff71cd97bf9c
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673b6bf7b37ef800087e8f11
Deploy Preview https://deploy-preview-3586--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mimowo commented 1 week ago

/lgtm Leaving final (approve) tagging to @tenzen-y . IIUC we then cherry-pick it to 0.9 and update the release notes on the page.

k8s-ci-robot commented 1 week ago

LGTM label has been added.

Git tree hash: 96da99eb4452fc563edba4f4652193da71f4d5d6

tenzen-y commented 1 week ago

/ok-to-test

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwysokin, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 week ago

/cherry-pick release-0.9

k8s-infra-cherrypick-robot commented 1 week ago

@tenzen-y: new pull request created: #3597

In response to [this](https://github.com/kubernetes-sigs/kueue/pull/3586#issuecomment-2487550543): >/cherry-pick release-0.9 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tenzen-y commented 1 week ago

/cherry-pick website

k8s-infra-cherrypick-robot commented 1 week ago

@tenzen-y: new pull request created: #3598

In response to [this](https://github.com/kubernetes-sigs/kueue/pull/3586#issuecomment-2487582975): >/cherry-pick website > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tenzen-y commented 1 week ago

In any case, the notification would be helpful. Thanks!

I will update the release page changelog, later.

/lgtm /approve

I updated the release page.

Screenshot 2024-11-22 at 17 23 08