search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Added Log output for LocalQueue and ClusterQueue #3605

Open 7h3-3mp7y-m4n opened 1 week ago

7h3-3mp7y-m4n commented 1 week ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR added Log output for LocalQueue and ClusterQueue

Which issue(s) this PR fixes:

Fixes #3527

Special notes for your reviewer:

It added some log output for better debugging without breaking the function..

Does this PR introduce a user-facing change?

NONE

NONE
k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 7h3-3mp7y-m4n Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 week ago

Welcome @7h3-3mp7y-m4n!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 week ago

Hi @7h3-3mp7y-m4n. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 84d415a9f278ac3b992e00de3a849c413a901556
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/674721ffe9e583000850bb3a
k8s-ci-robot commented 1 week ago

@mbobrovskyi: /release-note-edit must be used with a release note block.

In response to [this](https://github.com/kubernetes-sigs/kueue/pull/3605#issuecomment-2490131869): >/release-note-edit >``` >NONE >``` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mbobrovskyi commented 1 week ago

/ok-to-test

mbobrovskyi commented 1 week ago

/release-note-edit 

NONE
mimowo commented 1 week ago

/assign @gabesaba

gabesaba commented 6 days ago

There are some other log lines related to this issue:

e.g. these two, as AddOrUpdateWorkload calls AddOrUpdateWorkloadWithoutLock https://github.com/kubernetes-sigs/kueue/blob/2c8e7da1a23f2bc7218a2f08a2c9858a316fb053/pkg/controller/core/workload_controller.go#L602-L604 https://github.com/kubernetes-sigs/kueue/blob/2c8e7da1a23f2bc7218a2f08a2c9858a316fb053/pkg/controller/core/workload_controller.go#L744-L746

Could you track those down - there may be more than just the two I linked - and update them as well please?

7h3-3mp7y-m4n commented 6 days ago

There are some other log lines related to this issue:

e.g. these two, as AddOrUpdateWorkload calls AddOrUpdateWorkloadWithoutLock

https://github.com/kubernetes-sigs/kueue/blob/2c8e7da1a23f2bc7218a2f08a2c9858a316fb053/pkg/controller/core/workload_controller.go#L602-L604

https://github.com/kubernetes-sigs/kueue/blob/2c8e7da1a23f2bc7218a2f08a2c9858a316fb053/pkg/controller/core/workload_controller.go#L744-L746

Could you track those down - there may be more than just the two I linked - and update them as well please?

Yeah, I'll do that as well :)

7h3-3mp7y-m4n commented 2 days ago

Hey @mbobrovskyi and @gabesaba, The PR is still a work in progress, but I wanted to share what I've done so far and check if I'm on the right track. While working on it, I noticed a similar cache function here: workload_controller.go#L712. Should I update that as well? Also, for the test case, since I added a new parameter in the code, I think I'll need to update the test here: manager_test.go#L421. and I think I have to add a new parameter, am I right? Thanks!

mbobrovskyi commented 2 days ago

Hey @mbobrovskyi and @gabesaba, The PR is still a work in progress, but I wanted to share what I've done so far and check if I'm on the right track. While working on it, I noticed a similar cache function here: workload_controller.go#L712. Should I update that as well? Also, for the test case, since I added a new parameter in the code, I think I'll need to update the test here: manager_test.go#L421. and I think I have to add a new parameter, am I right? Thanks!

Yeah, we need to update tests as well.

7h3-3mp7y-m4n commented 2 days ago

Hey @mbobrovskyi and @gabesaba, The PR is still a work in progress, but I wanted to share what I've done so far and check if I'm on the right track. While working on it, I noticed a similar cache function here: workload_controller.go#L712. Should I update that as well? Also, for the test case, since I added a new parameter in the code, I think I'll need to update the test here: manager_test.go#L421. and I think I have to add a new parameter, am I right? Thanks!

Yeah, we need to update tests as well.

I'll share it with you ASAP, Thanks! @mbobrovskyi

k8s-ci-robot commented 1 day ago

@7h3-3mp7y-m4n: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main 84d415a9f278ac3b992e00de3a849c413a901556 link true /test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).