Closed alexandear closed 4 days ago
Hi @alexandear. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | 8136305139132811be0c68e7cadbd70817cf9865 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67422c7501bad70008937428 |
Deploy Preview | https://deploy-preview-3618--kubernetes-sigs-kueue.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexandear, tenzen-y
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Simplify code by replacing
strings.Compare
withcmp.Compare
or string comparison operators.Special notes for your reviewer:
https://pkg.go.dev/cmp#Compare
The PR enables
gocritic.stringsCompare
to automatically search for unnecessarystrings.Compare
.Does this PR introduce a user-facing change?