kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Simplify functions by removing strings.Compare #3618

Closed alexandear closed 4 days ago

alexandear commented 5 days ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Simplify code by replacing strings.Compare with cmp.Compare or string comparison operators.

Special notes for your reviewer:

https://pkg.go.dev/cmp#Compare

The PR enables gocritic.stringsCompare to automatically search for unnecessary strings.Compare.

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 5 days ago

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 5 days ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 8136305139132811be0c68e7cadbd70817cf9865
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67422c7501bad70008937428
Deploy Preview https://deploy-preview-3618--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mbobrovskyi commented 4 days ago

/ok-to-test

k8s-ci-robot commented 4 days ago

LGTM label has been added.

Git tree hash: 589355ce6a9bd3f42bf802b43290474094ab7124

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment