TAS: Rank-ordering support for Pod groups

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.49k stars 267 forks source link

TAS: Rank-ordering support for Pod groups #3649

Closed PBundyra closed 3 days ago

PBundyra commented 5 days ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new label for Pod groups "kueue.x-k8s.io/pod-group-index"
Adds TAS rank-ordering support for Pod groups

Which issue(s) this PR fixes:

Fixes #3533

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

Support rank-based ordering of Pods with Topology-Aware Scheduling. 
The Pod indexes are determined based on the "kueue.x-k8s.io/pod-group-index" label which
can be set by an external controller managing the group.

k8s-ci-robot commented 5 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

PBundyra commented 5 days ago

/assign @mimowo

netlify[bot] commented 5 days ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
Latest commit	2974e1c4042ae68eb7670b30bba984096d08c173
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67482eaae6f22100082ccb8d
Deploy Preview	https://deploy-preview-3649--kubernetes-sigs-kueue.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 5 days ago

LGTM label has been added.

Git tree hash: ab5296513f436fa3b3f495365c4fb3fade76154e

mimowo commented 5 days ago

Actually, the PodGroups as such were already supported by TAS, just not rank-based ordering.

/release-note-edit

Support rank-based ordering of Pods with Topology-Aware Scheduling. 
The Pod indexes are determined based on the "kueue.x-k8s.io/pod-group-index" label which
can be set by an external controller managing the group.

PBundyra commented 4 days ago

/retest

mimowo commented 4 days ago

The build is failing after the other PR: https://github.com/kubernetes-sigs/kueue/pull/3656. Please rebase and use corev1.LabelHostname

mimowo commented 3 days ago

/lgtm /approve @tenzen-y I believe all your comments since https://github.com/kubernetes-sigs/kueue/pull/3649#pullrequestreview-2464833242 are addressed, so merging to move forward, and unblock the follow up work on https://github.com/kubernetes-sigs/kueue/issues/3663. If you have some extra last minute comments feel free to still add them even after merged. /hold cancel

k8s-ci-robot commented 3 days ago

LGTM label has been added.

Git tree hash: fa53e63ff952ffaa065e789e81bc284e4e1bee84

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment