search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Implement Topology CRD validations testing #3657

Closed tenzen-y closed 2 days ago

tenzen-y commented 3 days ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We used to implement validation and mutating testing based on webhooks and markers in the /test/integration/webhook/core.

However, for Topology, we do not have any testing for those.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
netlify[bot] commented 3 days ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 190ddf9ac783a900897c123b3a923bdcda27e6ee
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6746d672448c0a0008679d53
mbobrovskyi commented 2 days ago

/lgtm

Thanks!

k8s-ci-robot commented 2 days ago

LGTM label has been added.

Git tree hash: ec7fe0f5ed5f6d345996d9a8ecf1546a9da3476d

tenzen-y commented 2 days ago

/hold

mimowo commented 2 days ago

/lgtm /approve I think the PR is ready. We can think how to improve readability of the tests in a follow up more holistically. Feel free to release the hold.

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/test/OWNERS)~~ [mimowo,tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 days ago

LGTM label has been added.

Git tree hash: c7ceb2d84092bea3853f7e8d2549f527bfe259e6

tenzen-y commented 2 days ago

/hold cancel