search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.49k stars 267 forks source link

TAS: Move sorting domains lexicographically from TopologyUngater to TAS Snapshot #3672

Closed PBundyra closed 4 days ago

PBundyra commented 4 days ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Reduce the amount of sorting as in TAS Snapshot it's done only once . Account for future changes regarding #3671

Which issue(s) this PR fixes:

Part of #3671

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 4 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

PBundyra commented 4 days ago

/cc @mimowo

netlify[bot] commented 4 days ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit bde5568dc82113fa0b3d6e93ec86f71c05b1acbe
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67474bac9dbdf60008a1968a
Deploy Preview https://deploy-preview-3672--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mimowo commented 4 days ago

/lgtm /approve Thanks! This will avoid repeated sorting by TopologyUngater on every reconcile, but more importantly it will prepare for https://github.com/kubernetes-sigs/kueue/issues/3671.

k8s-ci-robot commented 4 days ago

LGTM label has been added.

Git tree hash: faa77cd4cc47e82cfce0b5dd798ce243bccd345a

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment