search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.49k stars 267 forks source link

Fix rolling update for StatefulSet integration #3684

Open mbobrovskyi opened 3 days ago

mbobrovskyi commented 3 days ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix rolling update for StatefulSet integration

Which issue(s) this PR fixes:

Fixes #3690

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed rolling update for StatefulSet integration
k8s-ci-robot commented 3 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

netlify[bot] commented 3 days ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 45c310b3e6558dad0394a57fa984e868bc4677f1
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6749d131a1ee3100083ab115
mbobrovskyi commented 2 days ago

/hold for #3686

mbobrovskyi commented 2 days ago

/unhold

mimowo commented 2 days ago

LGTM, just nits from me. I think we could consider a dedicated KEP for serving workloads, where we could mention the new annotation (and the fast-admission annotation added before), but I wouldn't like to block the PR on it before 0.10, as this is an important fix.

cc @tenzen-y

I synced with @mbobrovskyi and he will create a KEP for serving workloads - starting from the StatefulSet support. We will then extend the KEP with LeaderWorkerSet when we have a prototype. But I think it would be great to merge this for 0.10 anyway.

k8s-ci-robot commented 2 days ago

LGTM label has been added.

Git tree hash: 31d622888584bf77d17c73d3cb3d6166eecccc38

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 2 days ago

Alternatively I'm also good with a section in the PodGroup KEP entitles serving workload support.