kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.49k stars 267 forks source link

Fix flaky - Creating a multikueue admission check Should run a job on worker if admitted #3685

Open IrvingMg opened 3 days ago

IrvingMg commented 3 days ago

What type of PR is this?

/kind bug /kind flake

What this PR does / why we need it:

Adds a check when syncing jobs on multikueue to avoid trying to patch the spec before resuming the job.

Which issue(s) this PR fixes:

Fixes #3600

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IrvingMg Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/controller/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/controller/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 days ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 90070812b68375909bc8c8c377946514984d3ed4
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6748a8e320f2a8000815f1e4
Deploy Preview https://deploy-preview-3685--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 3 days ago

@IrvingMg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main 90070812b68375909bc8c8c377946514984d3ed4 link true /test pull-kueue-test-unit-main
pull-kueue-test-integration-main 90070812b68375909bc8c8c377946514984d3ed4 link true /test pull-kueue-test-integration-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).