kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.48k stars 265 forks source link

Add kueue.x-k8s.io/pod-group-serving annotation. #3686

Closed mbobrovskyi closed 1 hour ago

mbobrovskyi commented 19 hours ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add kueue.x-k8s.io/pod-group-serving annotation that allow to disable reclaim pods for serving workloads.

Which issue(s) this PR fixes:

Fixes #3683

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add kueue.x-k8s.io/pod-group-serving annotation that allow to avoid reclaim pods for serving workloads.
k8s-ci-robot commented 19 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi Once this PR has been reviewed and has the lgtm label, please assign kerthcet, moficodes, trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/controller/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/controller/OWNERS)** - **[pkg/util/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/pkg/util/OWNERS)** - **[site/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/site/OWNERS)** - **[test/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/test/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 19 hours ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit e87ab94dfb5481928bc025c076d81b969a17ccb8
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6748cf3f051b7e0008d27546
mbobrovskyi commented 19 hours ago

/cc @mimowo

mbobrovskyi commented 1 hour ago

/close Due to we will merge it on https://github.com/kubernetes-sigs/kueue/pull/3684.