kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
11.09k stars 2.26k forks source link

feat(cmd): add local-config annotation on create #5798

Open bt-macole opened 3 weeks ago

bt-macole commented 3 weeks ago

this adds a DefaultMetadata object in konfig that can be used when creating a new kustomization yaml that conforms with the best practice recommendations in the kustomize docs.

The Kustomization config in a kustomization.yaml SHOULD contain this annotation so that tools know it is not intended to be sent to the Kubernetes api server.

resolves: #5746

k8s-ci-robot commented 3 weeks ago

Hi @bt-macole. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bt-macole Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kustomize/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stormqueen1990 commented 2 weeks ago

Hi there, @bt-macole!

The commit message in this PR is currently invalid because commit messages cannot contain closing keywords, at (@) mentions or hashtag (#) references, as per https://github.com/kubernetes-sigs/kustomize/pull/5798#issuecomment-2465250854

Could you please amend this commit message to fix the issue?

bt-macole commented 2 weeks ago

Hi there, @bt-macole!

The commit message in this PR is currently invalid because commit messages cannot contain closing keywords, at (@) mentions or hashtag (#) references, as per #5798 (comment)

Could you please amend this commit message to fix the issue?

done! ty

stormqueen1990 commented 1 week ago

/test all

bt-macole commented 1 week ago

per this comment

/assign knverey