kubernetes-sigs / release-team-shadow-stats

Kubernetes release team shadow program application analysis
Apache License 2.0
14 stars 6 forks source link

Project refactoring #17

Closed leonardpahlke closed 2 years ago

leonardpahlke commented 2 years ago

Project refactoring & cleanup

/kind clean-up /kind feature

Fixes #11 Fixes #6

Info: Regarding which diagrams can be published publicly (see #7):

This PR removes pronoun diagrams and subteam diagrams. After a conversation with @palnabarun a few weeks ago, I remembered the CoCC expressing concern about showing pronouns of applicants in a chart (even if anonymized) + regarding the other charts... the "number of applicants for the release team subteams" is sometimes too low to create charts (applicants could be tracked).

k8s-ci-robot commented 2 years ago

@leonardpahlke: The label(s) kind/clean-up cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/release-team-shadow-stats/pull/17): >Project refactoring & cleanup > >* Moving files into a source directory & improve general usability (see #6) >* General refactoring of almost all methods to improve usability and the option to configure the project for each release (#6) >* Use the [polars](https://pola.rs/) library instead of the [pandas](https://pandas.pydata.org/) to process 'data-frames' >* Add new charts (see #11) > >/kind clean-up >/kind feature > >Fixes #11 >Fixes #6 > >Info: >Regarding which diagrams can be published publicly (see #7): > >This PR removes pronoun diagrams and subteam diagrams. After a conversation with @palnabarun a few weeks ago, I remembered the CoCC expressing concern about showing pronouns of applicants in a chart (even if anonymized) + regarding the other charts... the "number of applicants for the release team subteams" is sometimes too low to create charts (applicants could be tracked). > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leonardpahlke commented 2 years ago

Hello 👋 @puerco / @cpanato friendly ping – do you find time to review the code in the next days? Otherwise, I would kindly ask via slack for volunteers 🙂👍

leonardpahlke commented 2 years ago

/priority important-soon

cc @palnabarun @saschagrunert

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/release-team-shadow-stats/blob/main/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
saschagrunert commented 2 years ago

/lgtm