Closed MatthiasWerning closed 9 months ago
@MatthiasWerning do you mind sending a pull request? Master first, but we can fix release-8.0 too.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Closed in favor of #159
It seems to me that the provisioning controller does not react to any context cancellation that was passed down the chain from the calling application / library.
This is probably due to the
select {}
statement in line 862 ofcontroller/controller.go
. Thus theclaimQueue
andvolumeQueue
will effectively never be shutdown since the localrun(ctx context.Context)
function never returns (with exception to an unsuccessful cache sync await).Would be great if this could be fixed in v8 as well. This probably just requires the
select {}
to be replaced by<-ctx.Done()
as far as I tried it using my own provisioning controller.