make CNI_NAME target - Githubissues

dougsland commented 2 years ago

Would be nice to have calico and antrea or others CNI as target so easy to clone and deploy a working environment with your favourite CNI.

Example: # make calico will execute behind the scenes in the makefile:

calico:
     @sed -i 's/cni:.*/cni: "calico"/g' sync/shared/variables.yaml
     $(MAKE) -e 2 (or all or the target that trigger the build of the project)

The same apply to the others CNI supported by the project.

dougsland commented 2 years ago

/good-first-issue

k8s-ci-robot commented 2 years ago

@dougsland: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/sig-windows-dev-tools/issues/156): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jayunit100 commented 2 years ago

spoke w/ doug and amim - we can make a large MR to fix this in side of #177

kubernetes-sigs / sig-windows-dev-tools

make CNI_NAME target #156

Guidelines