search

kubernetes-sigs / sig-windows-dev-tools

This is a batteries included local development environment for Kubernetes on Windows.
Apache License 2.0
80 stars 46 forks source link

Fix Windows 1.4.0 antrea manifests #197

Closed knabben closed 2 years ago

knabben commented 2 years ago
  1. Using tagged helper.psm1 installation script, before was getting from master and a latest change broke the install script - https://github.com/antrea-io/antrea/pull/3730
  2. SSL.exe installation is not working instead downloading the OVS DLL dependencies directly

TODO: Need to change these files to the bucket.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/sig-windows-dev-tools/blob/master/OWNERS)~~ [knabben] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knabben commented 2 years ago 
I'm whoami-windows-59cd7b4974-8kbl5 running on windows/amd64
knabben commented 2 years ago

/close

it was fixed on Antrea

k8s-ci-robot commented 2 years ago

@knabben: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/sig-windows-dev-tools/pull/197#issuecomment-1218313907): >/close > >it was fixed on Antrea Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.