kubernetes / cloud-provider-openstack

Apache License 2.0
615 stars 603 forks source link

[release-1.30] [occm] add a node selector support for loadbalancer services #2603

Closed k8s-infra-cherrypick-robot closed 4 months ago

k8s-infra-cherrypick-robot commented 4 months ago

This is an automated cherry-pick of #2601

/assign kayrus

added a node selector support for loadbalancer services
jichenjc commented 4 months ago

I assume we are lack of 1.30 CI test now..suggest to create that first before we merge this PR

/lgtm /hold

dulek commented 4 months ago

/approve

CI's running now, let's unhold once it passes.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.30/OWNERS)~~ [dulek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kayrus commented 4 months ago

it's green :tada: /unhold

kayrus commented 4 months ago

/hold

kayrus commented 4 months ago

@jichenjc do we need to wait for https://github.com/kubernetes/cloud-provider-openstack/issues/2606 ?

jichenjc commented 4 months ago

@jichenjc do we need to wait for https://github.com/kubernetes/cloud-provider-openstack/issues/2606 ?

I can't see the history now , originally 1.30 only test UT but no functional CI test 2606 added CI for 1.30 so should able to test 1.30 after that as no CI history from here can be seen might need keep an eye