search

kubernetes / cloud-provider-openstack

Apache License 2.0
623 stars 611 forks source link

[manila-csi-plugin] support muilple share rules #2727

Open moonek opened 1 week ago

moonek commented 1 week ago

What this PR does / why we need it:

Support muilple share rules.

Which issue this PR fixes(if applicable): fixes #2725

Special notes for reviewers:

As I don't have a cephfs environment, I can't verify this PR.

Release note:

[manila-csi-plugin] support muilple share rules
k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gman0 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/csi/manila/OWNERS](https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/csi/manila/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 week ago

Hi @moonek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.