search

kubernetes / cloud-provider-vsphere

Kubernetes Cloud Provider for vSphere https://cloud-provider-vsphere.sigs.k8s.io
Apache License 2.0
244 stars 177 forks source link

Bump govmomi to v0.45.1 #1303

Closed zhanggbj closed 3 weeks ago

zhanggbj commented 3 weeks ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/cloud-provider-vsphere/blob/master/OWNERS)~~ [zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhanggbj commented 3 weeks ago

/hold waiting for E2E test here https://github.com/team-cluster-api/cloud-provider-vsphere/pull/73

/assign @DanielXiao /assign @sbueringer /assign @XudongLiuHarold

sbueringer commented 3 weeks ago

/lgtm

zhanggbj commented 3 weeks ago

https://github.com/team-cluster-api/cloud-provider-vsphere/pull/73 E2E passed.

Merge it /unhold