search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.4k stars 1.46k forks source link

CEL for Admission Control #3488

Open jpbetz opened 2 years ago

jpbetz commented 2 years ago

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Rishit-dagli commented 1 year ago

Hello @jpbetz @cici37 :wave:, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli commented 1 year ago

Hey @jpbetz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Atharva-Shinde commented 1 year ago

Hey again @cici37 @jpbetz :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

cici37 commented 1 year ago

Hi @Atharva-Shinde here is the placeholder doc PR: https://github.com/kubernetes/website/pull/42042 Thank you!

Atharva-Shinde commented 1 year ago

Hey @cici37 does this enhancement have any code related pull requests open in kubernetes/kubernetes repository?

cici37 commented 1 year ago

Hey @cici37 does this enhancement have any code related pull requests open in kubernetes/kubernetes repository?

I have updated in issue description. Thank you!

Atharva-Shinde commented 1 year ago

Hello @cici37 @jpbetz šŸ‘‹, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PRs associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone. https://github.com/kubernetes/kubernetes/pull/119215 https://github.com/kubernetes/kubernetes/pull/119109 https://github.com/kubernetes/kubernetes/pull/118819 https://github.com/kubernetes/kubernetes/pull/118644

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

Atharva-Shinde commented 1 year ago

Thanks for filling an exception request! I'll reapply the v1.28 milestone if the exception request is approved.

Rishit-dagli commented 1 year ago

Hello @cici37 @jpbetz :wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: https://github.com/kubernetes/website/pull/42042

Rishit-dagli commented 1 year ago

@Atharva-Shinde was this exception request approved?

cici37 commented 1 year ago

@Rishit-dagli Yes, this exception has been approved and we are on track for 1.28.

cici37 commented 1 year ago

Update: All code was merged before the 1.28 exception deadline. Thank you so much for the support! cc @Atharva-Shinde @Rishit-dagli

Atharva-Shinde commented 1 year ago

Hey again @cici37 šŸ‘‹ As all the code related PRs of this KEP were merged by the additional time approved in the exception request, I am adding this KEP back to v1.28 milestone and changing the status of this enhancement to Tracked :)

/milestone v1.28

npolshakova commented 1 year ago

/remove-label lead-opted-in

npolshakova commented 11 months ago

Hi @cici37, is this target 1.29? If it is, can you add the lead-opted-in label so that it is correctly tracked by the 1.29 Enhancements project board? Thanks!

cici37 commented 11 months ago

Hi @cici37, is this target 1.29? If it is, can you add the lead-opted-in label so that it is correctly tracked by the 1.29 Enhancements project board? Thanks!

Hi @npolshakova, Thanks for checking. This KEP is not targeting 1.29. We plan to use 1.29 mainly for bug fixing. Thanks!

jpbetz commented 11 months ago

/label lead-opted-in

rayandas commented 11 months ago

Hello @jpbetz šŸ‘‹, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

cici37 commented 11 months ago

@rayandas Thanks for the updates. I have raised PR to update the latest milestone: https://github.com/kubernetes/enhancements/pull/4272

rayandas commented 11 months ago

@cici37 Please try to get it merged before the enhancements freeze. Thanks.

cici37 commented 11 months ago

@rayandas It is merged. Thanks!

rayandas commented 11 months ago

As #4272 is now merged, marking this as Tracked for Enhancements Freeze. šŸš€ Thanks.

taniaduggal commented 11 months ago

Hey there @jpbetz ! šŸ‘‹, v1.29 Docs team shadow here. Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release. Thank you!

jpbetz commented 11 months ago

^ @cici37

cici37 commented 11 months ago

We might not need a doc PR for this release. We'll raise one later if the doc update is needed.

rayandas commented 10 months ago

Hey again @jpbetz šŸ‘‹, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

Please update the Issue description to include all the related PRs of this KEP under the beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

a-mccarthy commented 10 months ago

Hi @jpbetz, šŸ‘‹ from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

jpbetz commented 10 months ago

Hi @jpbetz , šŸ‘‹ from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

Not for this release. We're letting this feature settle in as a Beta feature with only relatively minor improvements.

@cici37 please feel free to disagree if you'd like to publish anything.

npolshakova commented 10 months ago

Hey again @cici37 @jpbetz šŸ‘‹, 1.29 Enhancements team here! Are there any code PRs going into 1.29 we should track as part of this KEP? Or could you confirm that there are no net new code changes in 1.29?

npolshakova commented 10 months ago

Confirmed that 1.29 code changes had mainly bug fixes, marking this as tracked for code freeze šŸš€

liggitt commented 8 months ago

Is this targeting stable in 1.30?

salehsedghpour commented 8 months ago

/remove-label lead-opted-in

salehsedghpour commented 8 months ago

Hello šŸ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

cici37 commented 8 months ago

Yes we plan to promote this to GA in 1.30.

/milestone v1.30

@jpbetz Could you please tag the leader opt in label here? Thanks!

jpbetz commented 8 months ago

/lead opt-in

jpbetz commented 8 months ago

/label lead-opted-in

sreeram-venkitesh commented 7 months ago

Hello @cici37, @jpbetz šŸ‘‹, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

The status of this enhancement is marked as tracked for enhancement freeze šŸŽ‰ Thank you!

Princesso commented 7 months ago

Hello @jpbetz , šŸ‘‹ 1.30 Docs Shadow here. Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

kcmartin commented 7 months ago

Hi @jpbetz, @cici37,

šŸ‘‹ from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

fkautz commented 6 months ago

Hi @jpbetz, @cici37

šŸ‘‹ from the v1.30 Communications Team!

We are currently working on the midcycle blog. We are looking for a paragraph or two about significant enhancements. Are you interested in participating?

Here's the link for general access (commenter permissions). We can extend editor permissions if you choose to author an entry in this blog post.

Also, please get in touch with us if there are other changes you believe could impact users that we should highlight. We can be reached at #release-comms in the Kubernetes Slack.

Cheers, Frederick

sreeram-venkitesh commented 6 months ago

Hey again @jpbetz, @cici37 šŸ‘‹ v1.30 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024.

Here's where this enhancement currently stands:

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the issue description to include all the related PRs of this KEP):

Currently, I'm marking this KEP as At Risk for Code Freeze. Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sreeram-venkitesh commented 6 months ago

@cici37, @jpbetz Please let me know if https://github.com/kubernetes/kubernetes/pull/123405 is the only code PR that needs to be merged for this KEP. Pinging again since code freeze is tomorrow.

jpbetz commented 6 months ago

Please let me know if kubernetes/kubernetes#123405 is the only code PR that needs to be merged for this KEP. Pinging again since code freeze is tomorrow.

We're also merging https://github.com/kubernetes/kubernetes/pull/123543. It's in the merge queue now. I've added it to the description for tracking. https://github.com/kubernetes/kubernetes/pull/123405 is ready and will be merged after.

sreeram-venkitesh commented 6 months ago

Thank you @jpbetz, @cici37!

With all the implementation (code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.30 Code Freeze!

sreeram-venkitesh commented 4 months ago

Hi @jpbetz šŸ‘‹, 1.31 Enhancements Lead here.

Since this KEP has graduated to GA in 1.30, please update the status here in the kep.yaml to implemented so that we can close this issue.

/remove-label lead-opted-in

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten