Controller does not recreate removed ingress-nginx-controller service of LoadBalancer type, nor if removed its LB

[bd-spl]

What happened:

Ingress Nginx Controller does not recreate removed ingress-nginx-controller service of LoadBalancer type, nor the LB itself. The service needs to be recreated in order to apply changed annotations, for example, from internal to internet-facing LB type.

What you expected to happen:

If the service and/or LB removed manually, controller recreates it back. If annotation change for the service, controller recreates the service and/or its LB.

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.):

NGINX Ingress controller
  Release:       v1.5.2
  Build:         e0733c7fd0520ec8d7f351ca49b09199d35d35df
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.21.6

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.7-eks-4721010", GitCommit:"b77d9473a02fbfa834afa67d677fd12d690b195f", GitTreeState:"clean", BuildDate:"2022-06-27T22:22:16Z", GoVersion:"go1.17.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.13-eks-fb459a0", GitCommit:"55bd5d5cb7d32bc35e4e050f536181196fb8c6f7", GitTreeState:"clean", BuildDate:"2022-10-24T20:35:40Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}

Environment:

• Cloud provider or hardware configuration: AWS EKS

• OS (e.g. from /etc/os-release):

• Kernel (e.g. uname -a):

• Install tools:

  • Please mention how/where was the cluster created like kubeadm/kops/minikube/kind etc.

• Basic cluster related info:

  • kubectl version
  • kubectl get nodes -o wide

    NAME                                        STATUS   ROLES    AGE   VERSION               INTERNAL-IP   EXTERNAL-IP   OS-IMAGE         KERNEL-VERSION                 CONTAINER-RUNTIME
    ip-xxx  Ready    <none>   2d    v1.23.9-eks-ba74326   xxx   <none>        Amazon Linux 2   5.4.209-116.367.amzn2.x86_64   containerd://1.6.6
    ip-yyy   Ready    <none>   2d    v1.23.9-eks-ba74326   yyy    <none>        Amazon Linux 2   5.4.209-116.367.amzn2.x86_64   containerd://1.6.6

• How was the ingress-nginx-controller installed: helm provider by terraform (helm_release). Other details below are not relevant for this particular case (whatever config is deployed, the main problem is recreating the service/LB after it is removed).

  • If helm was used then please show output of helm ls -A | grep -i ingress
  • If helm was used then please show output of helm -n <ingresscontrollernamepspace> get values <helmreleasename>
  • If helm was not used, then copy/paste the complete precise command used to install the controller, along with the flags and options used
  • if you have more than one instance of the ingress-nginx-controller installed in the same cluster, please provide details for all the instances

• Current State of the controller:

  • kubectl describe ingressclasses
  • kubectl -n <ingresscontrollernamespace> get all -A -o wide
  • kubectl -n <ingresscontrollernamespace> describe po <ingresscontrollerpodname>
  • kubectl -n <ingresscontrollernamespace> describe svc <ingresscontrollerservicename>

• Current state of ingress object, if applicable:

  • kubectl -n <appnnamespace> get all,ing -o wide
  • kubectl -n <appnamespace> describe ing <ingressname>
  • If applicable, then, your complete and exact curl/grpcurl command (redacted if required) and the reponse to the curl/grpcurl command with the -v flag

• Others:

  • Any other related information like ;
  • copy/paste of the snippet (if applicable)
  • kubectl describe ... of any custom configmap(s) created and in use
  • Any other related information that may help

How to reproduce this issue:

Remove the LB service: kubectl delete svc/ingress-nginx-controller -n ingress-nginx, or its managed LB in AWS console/UI

Anything else we need to know:

[k8s-ci-robot]

@bd-spl: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[bd-spl]

w/a: full redeploy of the ingress-nginx addon with helm

[longwuyuan]

/remove-kind bug

• No well-known location has documented that changes to a helm release of the ingress controller is done by manually doing a kubectl delete. Where did you get that process from. You should follow up on that source as there may be other steps that were to be done after a delete
• Changes of any kind to a helm release of the ingress-nginx-controller are done via the helm upgrade command using a values file or the --set flags
• This looks like a deployment on EKS or AWS and if so, the documented install for AWS is not helm but https://kubernetes.github.io/ingress-nginx/deploy/

[longwuyuan]

I will close for now. Please re-open when required. /close

[k8s-ci-robot]

@longwuyuan: Closing this issue.

In response to [this](https://github.com/kubernetes/ingress-nginx/issues/9525#issuecomment-1399884327): >I will close for now. Please re-open when required. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.