kubernetes / kubectl

Issue tracker and mirror of kubectl code
Apache License 2.0
2.82k stars 909 forks source link

Add `kubectl` support for managing tolerations with imperative commands #1652

Closed satyampsoni closed 3 hours ago

satyampsoni commented 6 days ago

What would you like to be added: I would like to propose a new feature to enhance the kubectl command-line tool with the ability to manage tolerations more directly through imperative commands. Currently, the kubectl imperative commands do not offer an easy way to add tolerations to a pod or deployment without having to manually edit YAML files or use the kubectl apply workflow.

Screenshot from 2024-09-11 18-34-13

k8s-ci-robot commented 6 days ago

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ardaguclu commented 6 days ago

The recommended path for such feature requests is to build a plugin first and if it gets attraction by the community, consider to add it in kubectl as built-in command. However, I'm hesitant that we'd want additional imperative command as we recommend using the apply command for a long time.

ardaguclu commented 3 hours ago

I think we can close this as the recommended path is to create a plugin first. /close

k8s-ci-robot commented 3 hours ago

@ardaguclu: Closing this issue.

In response to [this](https://github.com/kubernetes/kubectl/issues/1652#issuecomment-2357741084): >I think we can close this as the recommended path is to create a plugin first. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.