search

kubernetes / kubectl

Issue tracker and mirror of kubectl code
Apache License 2.0
2.89k stars 924 forks source link

refactor(create job): remove redundant nil check #1678

Closed miyamo2 closed 1 week ago

miyamo2 commented 2 weeks ago

Removed the nil check for a slice that was performed before it's length check. This is linted in staticcheck as well. https://staticcheck.dev/docs/checks#S1009

linux-foundation-easycla[bot] commented 2 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 weeks ago

Welcome @miyamo2!

It looks like this is your first PR to kubernetes/kubectl 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubectl has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miyamo2

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/kubectl/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ardaguclu commented 1 week ago

We don't get pull requests directly in this repository. Instead it is automatically mirrored from kubernetes. /close

k8s-ci-robot commented 1 week ago

@ardaguclu: Closed this PR.

In response to [this](https://github.com/kubernetes/kubectl/pull/1678#issuecomment-2485465417): >We don't get pull requests directly in this repository. Instead it is automatically mirrored from kubernetes. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.