search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.85k stars 2.66k forks source link

Migrate kubetest2-kops k/k conformance tests to kops prow #33820

Closed rifelpet closed 1 week ago

rifelpet commented 1 week ago

Fixes https://github.com/kubernetes/kops/issues/16938 (hopefully)

Those jobs are failing with this error:

Error: error building complete spec: failed to get bucket details for "s3://k8s-kops-ci-prow/discovery/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-canary.test-cncf-aws.k8s.io": Could not retrieve location for AWS bucket k8s-kops-ci-prow

We've seen this happen when the job is running with a different AWS account than the bucket's account.

According to https://github.com/kubernetes/test-infra/issues/29722#issue-1746821972 the eks-prow-build-cluster is for jobs "that do not depend on external cloud assets"

These kubtest2-kops jobs depend on an existing S3 bucket for kops to function properly, so we'll move these jobs to the same prow cluster that other kops jobs use so that they share the same AWS account.

Eventually when kubetest2-kops supports boskos for AWS accounts (https://github.com/kubernetes/kops/pull/15542) and it supports creating ephemeral s3 buckets (https://github.com/kubernetes/kops/issues/16880), then it wont matter which AWS account these jobs run in. Until then these jobs can share the kops AWS account.

/cc @dims @ameukam

dims commented 1 week ago

/approve /lgtm

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/kops/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/OWNERS)~~ [dims,rifelpet] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 week ago

@rifelpet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/33820): >Fixes https://github.com/kubernetes/kops/issues/16938 >(hopefully) > >Those jobs are failing with this error: > >`Error: error building complete spec: failed to get bucket details for "s3://k8s-kops-ci-prow/discovery/e2e-e2e-ci-kubernetes-e2e-al2023-aws-conformance-canary.test-cncf-aws.k8s.io": Could not retrieve location for AWS bucket k8s-kops-ci-prow` > >We've seen this happen when the job is running with a different AWS account than the bucket's account. > >--- > >According to https://github.com/kubernetes/test-infra/issues/29722#issue-1746821972 the `eks-prow-build-cluster` is for jobs "that do not depend on external cloud assets" > >These kubtest2-kops jobs depend on an existing S3 bucket for kops to function properly, so we'll move these jobs to the same prow cluster that other kops jobs use so that they share the same AWS account. > >Eventually when kubetest2-kops supports boskos for AWS accounts (https://github.com/kubernetes/kops/pull/15542) and it supports creating ephemeral s3 buckets (https://github.com/kubernetes/kops/issues/16880), then it wont matter which AWS account these jobs run in. Until then these jobs can share the kops AWS account. > >/cc @dims @ameukam > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.