search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.85k stars 2.66k forks source link

provider-aws: fail fast in presubmits #33843

Closed cartermckinnon closed 3 days ago

cartermckinnon commented 3 days ago

Updates the provider-aws presubmits to fail if there's a bug in the scripting.

mmerkes commented 3 days ago

/lgtm

dims commented 3 days ago

/approve

k8s-ci-robot commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/cloud-provider-aws/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/cloud-provider-aws/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 days ago

@cartermckinnon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/33843): >Updates the provider-aws presubmits to fail if there's a bug in the scripting. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.