Issue with k8s.io/docs/tasks/service-catalog/install-service-catalog-using-sc/

kubernetes / website

Kubernetes website and documentation repo:

https://kubernetes.io

Creative Commons Attribution 4.0 International

4.6k stars 14.49k forks source link

Issue with k8s.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ #22008

Closed ingenthr closed 3 years ago

ingenthr commented 4 years ago

This is a Bug Report

Problem:

After getting "sc" tool, I then had to install cfssl and cfssljson. Those dependencies aren't listed. Chances are they were just already installed on the author's machine. It will fail thusly:

$ sc check
Dependency check failed
Error: cfssl,cfssljson commands not found in the PATH

Proposed Solution:

Page to Update: Update the page to include these dependencies and commands.

$ go get -u github.com/cloudflare/cfssl/cmd/cfssl
$ go get -u github.com/cloudflare/cfssl/cmd/cfssljson

sftim commented 4 years ago

I'm not sure whether or not https://kubernetes.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should stay given that https://github.com/kubernetes/website/issues/20232 is cleaning up third party content, and sc is fairly closely tied to GCP.

My gut feeling based on https://github.com/kubernetes/website/issues/13017, the content guide, and doc-policies-for-third-party-content is that https://k8s.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should go.

It's OK to link from https://k8s.io/ to a page that explains how to use sc to set up the Service Catalog extensions, and it's fine to bring that target page up to date.

/language en

sftim commented 4 years ago

I'm decided. https://kubernetes.io/docs/tasks/service-catalog/install-service-catalog-using-sc/ should go. @ingenthr this might not be quite what you'd hoped for - sorry!

ingenthr commented 4 years ago

Thanks for the update. The only thing I'm confused by is you said "sc is fairly closely tied to GCP". We've been using service brokers and service catalog as something neutral and I did come across docs that indicate GCP has deprecated service catalog.

In any case, I respect your change/decision. I'm just trying to fit Service Brokers and Service Catalog into whether or not it's something one should rely on. I know you can't answer that question though. :)

sftim commented 4 years ago

Installing Service Catalog? Fine. Installing it with sc? Problematic, because sc is fairly closely tied to GCP. See issue #13017.

sftim commented 4 years ago

I'd be happy to see a replacement page go up that doesn't mention sc at all but does cover how to set up Service Catalog, talk OSBAPI, try it out, etc.

ingenthr commented 4 years ago

Oh, I see! Thanks for the clarification.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/website/issues/22008#issuecomment-747847865): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.