kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.45k stars 14.35k forks source link

Empty feature state tag for "Memory QoS with cgroup v2" in "Pod Quality of Service Classes" page #45930

Closed antaloala closed 5 months ago

antaloala commented 5 months ago

FEATURE STATE for Memory QoS with cgroups v2 feature says Kubernetes v1.30 [] According to Feature Gates page it is still alpha, being first introduced in 1.22. Should not the FEATURE STATE line then say Kubernetes v1.22 [alpha] ?

dipesh-rawat commented 5 months ago

Page related to issue: https://kubernetes.io/docs/concepts/workloads/pods/pod-qos/#memory-qos-with-cgroup-v2 /language en

dipesh-rawat commented 5 months ago

/retitle Empty feature state tag for "Memory QoS with cgroup v2" in "Pod Quality of Service Classes" page /kind bug

dipesh-rawat commented 5 months ago

We should fix so that the correct feature state is reflected.

/priority backlog /triage accepted

dipesh-rawat commented 5 months ago

It appears that resolving this issue is straightforward. Simply updating the feature-state shortcode parameter in pod-qos.md (click here) will ensure that the correct feature state is reflected accurately. Thanks for bringing this to our attention!

Line to update: pod-qos.md (click here)

- {{< feature-state feature-gate-name="MemoryQoS" >}}
+ {{< feature-state feature_gate_name="MemoryQoS" >}}

/help

k8s-ci-robot commented 5 months ago

@dipesh-rawat: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/website/issues/45930): >It appears that resolving this issue is straightforward. Simply updating the `feature-state` shortcode parameter in [pod-qos.md (click here)](https://github.com/kubernetes/website/blob/e4731338d3a5b503f30fbdd968aa363e413c469d/content/en/docs/concepts/workloads/pods/pod-qos.md?plain=1#L90) will ensure that the correct feature state is reflected accurately. Thanks for bringing this to our attention! > >#### Line to update: [pod-qos.md (click here)](https://github.com/kubernetes/website/blob/e4731338d3a5b503f30fbdd968aa363e413c469d/content/en/docs/concepts/workloads/pods/pod-qos.md?plain=1#L90) >```diff >- {{< feature-state feature-gate-name="MemoryQoS" >}} >+ {{< feature-state feature_gate_name="MemoryQoS" >}} >``` > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
steve-hardman commented 5 months ago

I will want help with this.

/assign