Add open panel config and quick action

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration

https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle

MIT License

6 stars 0 forks source link

Add open panel config and quick action #90

Closed f1ames closed 7 months ago

f1ames commented 7 months ago

This PR adds config to change when Violations panel is shown, fixes #6. Also fixes #2.

It also introduces code action to show panel from code actions panel.

Needs https://github.com/kubeshop/vscode-sarif/pull/6 and https://github.com/kubeshop/vscode-sarif/pull/7 to be merged first.

monokle 20240130-1

Changes

As above.

Fixes

None.

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

f1ames commented 7 months ago

There appear to be a bunch of conflicts though. I might have to re-review after you resolved those.

Sure, feel free to take another look. Conflicts were due to the fact that both this PR and autofix one (which was merged earlier) registered code actions related stuff (event, registering, etc) in the exact same lines.

cc @WitoDelnat

f1ames commented 7 months ago

Hmmm, autofix related tests started failing, I need to take a look on this. Fixed in https://github.com/kubeshop/vscode-monokle/pull/90/commits/9b163c6fe7aaa4623c12ba2ab84f53b9860178dd - actions are added via different providers and test was waiting for only the first one to be added.