kubesphere / ks-installer

Install KubeSphere on existing Kubernetes cluster
https://kubesphere.io
Apache License 2.0
527 stars 744 forks source link

add TODO or some other comments at installRunner.py #1230

Open daniel-hutao opened 3 years ago

daniel-hutao commented 3 years ago

I found the following confusing code:


try:
    readyToEnabledList.remove("metrics_server")
except:
    pass

try:
    readyToEnabledList.remove("networkpolicy")

The "metrics_server" is enabled at preInstallTasks() func, and "networkpolicy" is NOT enabled anywhere.

I suggest that whether it is because the current configuration function is under development or because it is not going to be supported in the future, we need to add some comment here.

pixiake commented 3 years ago

Thanks for the suggestion.

The reason for removing these tasks from the tasks list is that they are executed individually.

networkpolicy is just a configuration, and there is no playbook being performed.