kubesphere / s2ioperator

Operator for Source to image
Apache License 2.0
47 stars 31 forks source link

Remove the webhook of s2iBuilderTemplate #169

Closed LinuxSuRen closed 7 months ago

LinuxSuRen commented 2 years ago

The existing webhook of the s2iBuilderTemplate is pretty easy, but it always causes potential issues. A better solution could be the controller method

ks-ci-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/s2ioperator/blob/master/OWNERS)~~ [LinuxSuRen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment