search

kubevirt / cloud-provider-kubevirt

Kubernetes cloud-provider for KubeVirt
Apache License 2.0
73 stars 34 forks source link

update x/net pkg #238

Closed davidvossel closed 1 year ago

mfranczy commented 1 year ago

Tests fail with:

error: error validating "STDIN": error validating data: ValidationError(KubevirtMachineTemplate.spec.template.spec): unknown field "virtualMachineBootstrapCheck" in io.x-k8s.cluster.infrastructure.v1alpha1.KubevirtMachineTemplate.spec.template.spec; if you choose to ignore these errors, turn validation off with --validate=false

davidvossel commented 1 year ago

i had to update the capk version to fix that error.

davidvossel commented 1 year ago

/retest

davidvossel commented 1 year ago

/retest

davidvossel commented 1 year ago

@mfranczy tests pass now, can you take another look?

mfranczy commented 1 year ago

sure

/approve /lgtm

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/cloud-provider-kubevirt/blob/main/OWNERS)~~ [mfranczy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment