[release-1.0] chore: Add flag for setting timeout for creating windows vms

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt

https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes

Apache License 2.0

26 stars 17 forks source link

[release-1.0] chore: Add flag for setting timeout for creating windows vms #283

Closed lyarwood closed 1 week ago

lyarwood commented 1 week ago

What this PR does / why we need it:

some Windows images require more time to download image. This commit adds new flag windows-ready-timeout, which will allow user to set higher timeout only for Windows VMs. All other OS distributions will use default timeout.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE

kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/release-1.0/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment