search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
429 stars 269 forks source link

Populators: Add to PVC' exclude velero backup label #3522

Closed ShellyKa13 closed 2 weeks ago

ShellyKa13 commented 2 weeks ago

When backing up with Velero if a PVC is terminating then the backup is marked as PartiallyFailed, while the backup is still valid to use and its more of a warning, PVC' should be transparent to the user so have the backup partiallyFailed because of PVC' is a bad user experience. To fix that added to all our PVC' an label so it will be excluded from the Velero backup. This is a fix for previous PR https://github.com/kubevirt/containerized-data-importer/pull/3500 Which added an annotation instead of label by accident.

What this PR does / why we need it: Jira-ticket: https://issues.redhat.com/browse/CNV-51023

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
ShellyKa13 commented 2 weeks ago

/cherrypick release-v1.60 /cherrypick release-v1.59 /cherrypick release-v1.58 /cherrypick release-v1.57

kubevirt-bot commented 2 weeks ago

@ShellyKa13: once the present PR merges, I will cherry-pick it on top of release-v1.57, release-v1.58, release-v1.59, release-v1.60 in new PRs and assign them to you.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3522#issuecomment-2466774532): >/cherrypick release-v1.60 >/cherrypick release-v1.59 >/cherrypick release-v1.58 >/cherrypick release-v1.57 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 2 weeks ago

/approve /lgtm

kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 2 weeks ago

/test pull-containerized-data-importer-fossa

coveralls commented 2 weeks ago

Coverage Status

coverage: 59.292% (+0.008%) from 59.284% when pulling df488338977aa5852d727f8cef9673c2da3ae4eb on ShellyKa13:exclude-prime-from-backup into a03c153fa99288864d83fece13ea0be5ea600d28 on kubevirt:main.

kubevirt-bot commented 2 weeks ago

@ShellyKa13: new pull request created: #3523

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3522#issuecomment-2466774532): >/cherrypick release-v1.60 >/cherrypick release-v1.59 >/cherrypick release-v1.58 >/cherrypick release-v1.57 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 weeks ago

@ShellyKa13: new pull request created: #3524

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3522#issuecomment-2466774532): >/cherrypick release-v1.60 >/cherrypick release-v1.59 >/cherrypick release-v1.58 >/cherrypick release-v1.57 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 weeks ago

@ShellyKa13: new pull request created: #3525

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3522#issuecomment-2466774532): >/cherrypick release-v1.60 >/cherrypick release-v1.59 >/cherrypick release-v1.58 >/cherrypick release-v1.57 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 weeks ago

@ShellyKa13: new pull request created: #3526

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3522#issuecomment-2466774532): >/cherrypick release-v1.60 >/cherrypick release-v1.59 >/cherrypick release-v1.58 >/cherrypick release-v1.57 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.