search

kubevirt / kubevirt-tekton-tasks

VM specific tasks for Tekton Pipelines
Apache License 2.0
31 stars 34 forks source link

feat(CNV-40411): set default instancetype and preference labels #543

Closed codingben closed 1 week ago

codingben commented 3 weeks ago

What this PR does / why we need it:

During execution of the disk-uploader, it should be able to get the default-instancetype and default-preference labels from the DV or PVC, and set them in the newly created containerDisk metadata afterwards.

Release note:

Set instancetype and preference on a newly created containerDisk before uploading it
codingben commented 3 weeks ago

/cc @ksimon1 @lyarwood

codingben commented 3 weeks ago

@ksimon1 @0xFelix @lyarwood Can you please review again? :)

codingben commented 3 weeks ago

@0xFelix This revision will apply key:value that you requested in your latest review. Can you please take a look?

codingben commented 3 weeks ago

I need to test these PR changes, and add unit tests after it. I'll mark it as draft at the moment.

codingben commented 2 weeks ago

This revision is a rebase to have unit tests in this PR.

codingben commented 2 weeks ago

This revision is have unit tests to test the GetLabelsFromExportSource() function from vmexport.go.

codingben commented 2 weeks ago

@0xFelix This revision has more test cases that you've asked for.

ksimon1 commented 1 week ago

/retest

codingben commented 1 week ago

@0xFelix Thanks. I've addressed your review comments in this revision.

codingben commented 1 week ago

@0xFelix Resolved your last review in this revision.

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, codingben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codingben commented 1 week ago

/retest

codingben commented 1 week ago

/retest

ksimon1 commented 1 week ago

/override ci/prow/win11-pipeline-example-test

openshift-ci[bot] commented 1 week ago

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/win11-pipeline-example-test

In response to [this](https://github.com/kubevirt/kubevirt-tekton-tasks/pull/543#issuecomment-2485203074): >/override ci/prow/win11-pipeline-example-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 1 week ago

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/win11-pipeline-example-test

In response to [this](https://github.com/kubevirt/kubevirt-tekton-tasks/pull/543#issuecomment-2485203074): >/override ci/prow/win11-pipeline-example-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ksimon1 commented 1 week ago

/override ci/prow/win2k22-pipeline-example-test

openshift-ci[bot] commented 1 week ago

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/win2k22-pipeline-example-test

In response to [this](https://github.com/kubevirt/kubevirt-tekton-tasks/pull/543#issuecomment-2485203543): >/override ci/prow/win2k22-pipeline-example-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 1 week ago

@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/win2k22-pipeline-example-test

In response to [this](https://github.com/kubevirt/kubevirt-tekton-tasks/pull/543#issuecomment-2485203543): >/override ci/prow/win2k22-pipeline-example-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ksimon1 commented 1 week ago

the failing tests are not related to this change.

ksimon1 commented 1 week ago

/lgtm