VM rollout strategy - Githubissues

kubevirt / user-guide

This user guide will walk you through installation and various features.

https://kubevirt.io/user-guide

Apache License 2.0

64 stars 235 forks source link

VM rollout strategy #758

Closed jean-edouard closed 8 months ago

jean-edouard commented 10 months ago

What this PR does / why we need it: Updating CPU hotplug documentation and add a pages about VM rollout strategies

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

jean-edouard commented 9 months ago

/cc @fabiand @vladikr @xpivarc @fossedihelm

jean-edouard commented 9 months ago

Thanks @jean-edouard Some comments below, most of them related to struct vs string implementation. PTAL thank you!

Thank you for the review! Sorry for the outdated stuff, I should have made sure everything was up-to-date before requesting reviews... I should have addressed all your comments. Not sure why all lanes are failing...

jean-edouard commented 9 months ago

/retest

jean-edouard commented 9 months ago

/retest

fossedihelm commented 9 months ago

@jean-edouard https://github.com/kubevirt/user-guide/pull/767

jean-edouard commented 9 months ago

Added a temporary build fix, will revert once https://github.com/kubevirt/user-guide/pull/767 merges

fossedihelm commented 9 months ago

@acardace @aburdenthehand Would you mind to have a look? I think it is good to have documentation for the upcoming release containing the rollout strategy feature!

lyarwood commented 8 months ago

/cc

jean-edouard commented 8 months ago

Great stuff. Thanks for your patience on the review. I've only got some suggestions on wording and markup for readability.

Thanks a lot @aburdenthehand for the review! I just pushed basically all the changes you suggested (no need to re-read everything!)

aburdenthehand commented 8 months ago

/approve

aburdenthehand commented 8 months ago

/lgtm I think I can safely add this label again on @fossedihelm's behalf

jean-edouard commented 8 months ago

Rebased to fix conflict. No change.

aburdenthehand commented 8 months ago

/lgtm /approve

kubevirt-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand, dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/user-guide/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jean-edouard commented 8 months ago

/hold cancel @fossedihelm PTAL (just addressed Daniel's comment)

fossedihelm commented 8 months ago

Thanks @jean-edouard /lgtm