Live Migration: Add primary pod NIC name limitation

orelmisan commented 1 month ago

What this PR does / why we need it: Following https://github.com/kubevirt/kubevirt/pull/13018, it is possible to have a VM whose primary NIC is connected to a pod NIC with a name other than eth0.

In order for the migration to be successful, it is required for the both the source and target virt-launcher pods to have the same primary NIC name, for example: eth0.

[1] https://github.com/kubevirt/community/pull/324

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

orelmisan commented 1 month ago

/cc @EdDev

orelmisan commented 1 month ago

Change: Updated commit message to be more accurate.

vladikr commented 1 month ago

/approve Thanks

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/compute/OWNERS](https://github.com/kubevirt/user-guide/blob/main/docs/compute/OWNERS)~~ [vladikr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / user-guide

Live Migration: Add primary pod NIC name limitation #845