Closed viccuad closed 2 years ago
Relates to https://github.com/kubewarden/verify-image-signatures/pull/47#discussion_r1034836373
Make verify_cert(), return Result<SDK::BoolWithReason>. Response either returns:
verify_cert()
Result<SDK::BoolWithReason>
Ok(BoolWithReason::True)
Ok(BoolWithReason::False((reason))
`reason
Err(e)
e
Bump version to 0.8.5
No need.
Tagged 0.8.5 in main.
Description
Relates to https://github.com/kubewarden/verify-image-signatures/pull/47#discussion_r1034836373
Make
verify_cert()
, returnResult<SDK::BoolWithReason>
. Response either returns:Ok(BoolWithReason::True)
.Ok(BoolWithReason::False((reason))
with`reason
such as "cert not trusted by cert chain", or "cert expired".Err(e)
, withe
such as "cert not in PEM format", or "not_after datetime not in RFC 3339 format".Bump version to 0.8.5
Test
No need.
Additional Information
Tradeoff
Potential improvement