search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
433 stars 107 forks source link

feat(qrm): optimize admit logic #686

Closed nightmeng closed 3 months ago

nightmeng commented 3 months ago

What type of PR is this?

Features

What this PR does / why we need it:

Optimize the admit logic

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (99996fc) to head (58d14b3). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 80.00% 4 Missing and 1 partial :warning:
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 66.66% 4 Missing and 1 partial :warning:
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 85.71% 1 Missing :warning:
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 94.11% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #686 +/- ## ========================================== - Coverage 57.18% 57.11% -0.08% ========================================== Files 558 566 +8 Lines 54146 54495 +349 ========================================== + Hits 30966 31123 +157 - Misses 19305 19481 +176 - Partials 3875 3891 +16 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/686/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `57.11% <81.81%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.