kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
435 stars 107 forks source link

(feat)pap: power aware plugin = policy advisor + power eviction plugin + power capping plugin #696

Closed h-w-chen closed 3 weeks ago

h-w-chen commented 2 months ago

What type of PR is this?

feature: power aware plugin in sys-advisor

What this PR does / why we need it:

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

the power usage data collection part is not included yet. A locl impi reader shall be provided as temporary fillup; the ideal solution if getting power usage data from external data source like malachite.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 52.21239% with 378 lines in your changes missing coverage. Please review.

Project coverage is 55.89%. Comparing base (99996fc) to head (9677555). Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
...advisor/plugin/poweraware/capper/server/service.go 24.60% 92 Missing and 3 partials :warning:
...lugin/poweraware/evictor/server/evictor_service.go 37.75% 58 Missing and 3 partials :warning:
...nt/sysadvisor/plugin/poweraware/advisor/advisor.go 41.93% 45 Missing and 9 partials :warning:
.../agent/sysadvisor/plugin/poweraware/power_aware.go 30.76% 35 Missing and 1 partial :warning:
...sysadvisor/plugin/poweraware/capper/instruction.go 61.64% 23 Missing and 5 partials :warning:
...plugin/poweraware/capper/server/fanout_notifier.go 71.42% 13 Missing and 5 partials :warning:
...kg/agent/sysadvisor/plugin/poweraware/spec/spec.go 78.48% 16 Missing and 1 partial :warning:
...or/plugin/poweraware/evictor/percentage_evictor.go 58.97% 12 Missing and 4 partials :warning:
...sadvisor/plugin/poweraware/capper/server/server.go 0.00% 13 Missing :warning:
...gin/poweraware/advisor/action/strategy/strategy.go 80.95% 5 Missing and 3 partials :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #696 +/- ## ========================================== - Coverage 57.18% 55.89% -1.30% ========================================== Files 558 593 +35 Lines 54146 67813 +13667 ========================================== + Hits 30966 37907 +6941 - Misses 19305 25868 +6563 - Partials 3875 4038 +163 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/696/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/696/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.89% <52.21%> (-1.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.