search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
433 stars 107 forks source link

fix(qrm): fix cpu admit failed caused by float ceil #704

Closed nightmeng closed 1 month ago

nightmeng commented 1 month ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Fix cpu admit failed caused by float ceil

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.93750% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (56ba904) to head (1f93cf4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 90.00% 2 Missing and 1 partial :warning:
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 76.92% 2 Missing and 1 partial :warning:
...md/katalyst-agent/app/options/qrm/memory_plugin.go 50.00% 2 Missing :warning:
pkg/agent/qrm-plugins/util/util.go 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #704 +/- ## ========================================== + Coverage 57.17% 57.23% +0.05% ========================================== Files 570 570 Lines 54864 54871 +7 ========================================== + Hits 31370 31403 +33 + Misses 19540 19519 -21 + Partials 3954 3949 -5 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `57.23% <85.93%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.