search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
435 stars 107 forks source link

fix(qrm): fix printing of numa mem migrate container stats #710

Closed gary-lgy closed 1 week ago

gary-lgy commented 1 month ago

What type of PR is this?

Bug fix

What this PR does / why we need it:

Fix getting numa memory stats under cgroup v1.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (0a3785c) to head (e2eee22). Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 9 Missing :warning:
pkg/util/cgroup/manager/v1/fs_linux.go 0.00% 7 Missing :warning:
pkg/util/cgroup/manager/v2/fs_linux.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #710 +/- ## ========================================== + Coverage 55.86% 56.27% +0.40% ========================================== Files 573 594 +21 Lines 66777 68007 +1230 ========================================== + Hits 37307 38268 +961 - Misses 25489 25695 +206 - Partials 3981 4044 +63 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/710/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/710/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.27% <20.68%> (+0.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: