search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
435 stars 107 forks source link

fix (test): test code fix TestNodeMetricUpdate #730

Closed h-w-chen closed 3 days ago

h-w-chen commented 3 days ago

What type of PR is this?

Test fix

What this PR does / why we need it:

test code only - not production code sorting slice in deterministic order to ensure consistent equality check

Which issue(s) this PR fixes:

Untitled

Special notes for your reviewer:

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.99%. Comparing base (6273a71) to head (d8ee12e). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #730 +/- ## ========================================== - Coverage 56.05% 55.99% -0.06% ========================================== Files 597 597 Lines 67958 68036 +78 ========================================== + Hits 38094 38100 +6 - Misses 25807 25884 +77 + Partials 4057 4052 -5 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/730/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.99% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.