kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
https://kubeadmiral.io
Apache License 2.0
802 stars 95 forks source link

fix: avoid double counting of overflow replicas #300

Closed mrlihanbo closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (72fa461) 31.44% compared to head (5e8db37) 31.48%.

Files Patch % Lines
pkg/controllers/scheduler/framework/util.go 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #300 +/- ## ========================================== + Coverage 31.44% 31.48% +0.03% ========================================== Files 122 122 Lines 14346 14351 +5 ========================================== + Hits 4511 4518 +7 + Misses 9421 9419 -2 Partials 414 414 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/300/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/300/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `31.48% <83.33%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.