kubewharf / kubeadmiral

Multi-Cluster Kubernetes Orchestration
Apache License 2.0
658 stars 89 forks source link

bugfix(RCController): opInformer add wrong eventHandler #331

Closed zk-123 closed 2 weeks ago

zk-123 commented 2 weeks ago

i think opInformer add EventHandler use persistOpWorker instead of persistPpWorker

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (1f0e7ff) to head (0646de1). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/policyrc/controller.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #331 +/- ## ========================================== + Coverage 33.46% 33.47% +0.01% ========================================== Files 155 155 Lines 14627 14627 ========================================== + Hits 4895 4897 +2 + Misses 9222 9220 -2 Partials 510 510 ``` | [Flag](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/331/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubewharf/kubeadmiral/pull/331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `33.47% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.