search

kubo / rust-oracle

Oracle driver for Rust
193 stars 43 forks source link

document minimum rustc version & add to test matrix #58

Closed rursprung closed 2 years ago

rursprung commented 2 years ago

with this consumers get a guarantee for which rustc versions will work.

previously (up to at least version 0.5.1) it was possible to build this library with rustc 1.42.0, now it needs at least 1.54.0 due to this line: https://github.com/kubo/rust-oracle/blob/88b45ae4bccd9f48e820e1f7502bd0aee21be846/oracle_procmacro/src/lib.rs#L31

see also #57

see the commit messages for further details.

rursprung commented 2 years ago

@kubo: if i see this correctly you now include this in a slightly different manner with commit 546193c? in that case this PR here can be closed w/o merging (i'll let you double-check first, though)

kubo commented 2 years ago

@rursprung Sorry I didn't let you know.

if i see this correctly you now include this in a slightly different manner with commit https://github.com/kubo/rust-oracle/commit/546193cce7eaff843cec22cee7af3d2ac1821e30?

It is correct. I added the minimum rustc version to README.md and Cargo.toml as the rust-version field. CI picks up the minimum rustc version in Cargo.toml and uses it in the test matrix.