search

kubo / snzip

Snzip, a compression/decompression tool based on snappy
Other
217 stars 30 forks source link

add snzip spec file #6

Closed xianglei closed 10 years ago

xianglei commented 11 years ago

Great job!! and I love your awesome work

kubo commented 11 years ago

I have some questions. Well, I don't use rpm-based distribution. I wrote the followings with googling. If I misunderstand rpm spec, tell me.

I don't want to add version number to the spec file name and its contents. It must be changed by hand when a new version is released. I prefer to change it automatically when configure script runs.

The Summary: line is a short description, whereas %description is detailed description. IMO, it is better to change them as follows.

Summay: compress/decompress command line tool using snappy
... snip ...
%description
Snzip is compress/decompress command line tool using snappy.
This supports four type of file formats; snzip format, framing-format, snappy-java
format and snappy-in-java format. The default format is snzip.

Well, the default format will be changed to latest framing-format at the next release.

Why zlib is required to build snzip? IMO, snappy-devel should be used instead of zlib.

What is Url: http://www.phphiveadmin.net? The site is yours? IMO it should be URL about software, not the packager.

The Source: line should be URL according to http://www.rpm.org/max-rpm/s1-rpm-build-creating-spec-file.html.

xianglei commented 11 years ago

Well, maybe I forgot to change something, sorry about that things. I just wanna thank you for your great work. phphiveadmin.net is my personal website. Its a Hive(Hadoop) web ui tools. I use snappy on my hadoop cluster, and I often use your snzip on my cluster. So, thank you for your greate work again.