search

kubuzetto / behind

behind! addon source code repository
https://addons.mozilla.org/en-US/firefox/addon/behind/
Mozilla Public License 2.0
89 stars 3 forks source link

"Open image in new tab" function changed #11

Closed Liz-chan closed 3 years ago

Liz-chan commented 3 years ago

Before the latest update, I used to be able to right click an image and open it in a new tab in the extension view, and it would have the URL of the source website, but now it just leads to a blob URL which breaks my workflow since my other extensions can't act on it.

For example, if you right click and open in new tab, this is the URL it leads to: blob:chrome-extension://blfpdedbdighagggfhgihcocfheicfjk/f41ad91f-64c5-4570-94ed-547164a1436a

While before it lead to the actual image URL.

kubuzetto commented 3 years ago

Hi Liz-chan, thank you for the bug report! The behavior change here is a result of the fix to issue #10.

Instead of "Open Image in New Tab", if you use the "Open Link in New Tab" option and then click Ctrl+S; that will lead you to the original image URL instead of the blob. Does that option work with your workflow?

I will also be looking for a way to reduce the number of steps here. The specific way to access some image resources is making this cumbersome.

Liz-chan commented 3 years ago

Ah yeah, doing it that way works, but I preferred the link itself being there automatically rather than having to press Ctrl-S every time. To be more specific, I use an extension which retrieves the maximum size of an image on the server if it's been downscaled with arguments in the URL, and with behind it would open the image automatically and the extension would do its thing, but now there's another step I have to go through.

kubuzetto commented 3 years ago

I'll be looking further into this. The previous approach simply didn't work at all in certain pages, so I had to change it; but I believe I can find a middle ground here, allowing both behaviors.

Would you be willing to share the name of the other extension, so that I can test them together myself?

Liz-chan commented 3 years ago

Would you be willing to share the name of the other extension, so that I can test them together myself?

Sure, it's here https://github.com/qsniyg/maxurl

kubuzetto commented 3 years ago

Hi again, I just released 0.2.14; which makes the 'fetch as blob' behavior in 0.2.13 optional (i.e. it is invoked only if the original method fails to load the image). Can you check if the desired behavior is satisfied?

Liz-chan commented 3 years ago

Oh yeah it works great, ty