search

kubuzetto / behind

behind! addon source code repository
https://addons.mozilla.org/en-US/firefox/addon/behind/
Mozilla Public License 2.0
89 stars 3 forks source link

discuss.com.hk #6

Closed mkeroppi closed 3 years ago

mkeroppi commented 3 years ago

Does not seem to work for images in the main box on this page: https://www.discuss.com.hk/

kubuzetto commented 3 years ago

Can verify; the content menu was visible for neither the header nor the content. I will try to look into this tonight.

kubuzetto commented 3 years ago

Edit: Please disregard the original comment; I had messed up the browser settings trying something else then forgot to fix it (I was browsing in private mode constantly).

With default settings, the add-on seems to work as intended.

The original comment:

Huh, weird. Allowing the add-on to work on private windows made it work on the page. Can you please try the following steps?

  • Go to about:addons
  • Click on "behind!"
  • Under "Details", set "Run in Private Windows" to "Allow"
  • Go to discuss.com.hk
  • Right click on an image in the content (not header; the only actual image in the header is the facebook icon)
mkeroppi commented 3 years ago

The images in the screenshot attached cannot be captured using the extension.

Screenshot_2020-10-12 香港討論區(1)

kubuzetto commented 3 years ago

Ok, just to be on the same page - is this the behavior you're observing?

ss

mkeroppi commented 3 years ago

Ok, just to be on the same page - is this the behavior you're observing?

* On right-click, "behind" content menu appears

* When you click on it, the link seems broken and the image cannot be downloaded

ss

Yes. That is exactly correct.

kubuzetto commented 3 years ago

Ok here's one of the problematic URLs:

background-image:url('https://cdn.discuss.com.hk/t/3c2710/f/320x320/filters:extract_cover()/https://img.discuss.com.hk/d/attachments/day_201011/20201011_0e4f118b79b726be1169UXilRwXQknXp.jpg');

The regex I use for matching the URLs thinks that this part is the URL:

background-image:url(' https://cdn.discuss.com.hk/t/3c2710/f/320x320/filters:extract_cover( )

so obviously it cannot show the image afterwards.

I will try to come up with a better regex for this. Will release this as version 0.2.9 when I do.

Thanks for the bug report!

mkeroppi commented 3 years ago

That make sense now. Cross referenced to a long time bug in another extension. Thanks!

kubuzetto commented 3 years ago

0.2.9 includes the fix; the problem seems to be solved. Thanks :)