search

kumahq / kuma-demo

A demo app to illustrate the capabilities and advantages of Kuma. 🐻
https://kuma.io/
Apache License 2.0
57 stars 54 forks source link

docs(*) update correct pod/container ratio #129

Closed jaikratsinghtariyal closed 1 year ago

jaikratsinghtariyal commented 2 years ago

PR Details

Description

I think for first time, there will 1/1 mapping. It will be 2/2 until you start kuma CP.

Motivation and Context

Giving wrong steps.

Full changelog

corrected the documentation only

Issues resolved

NA

jpeach commented 2 years ago

Thanks @jaikratsinghtariyal . The DCO sign-off check is failing because you need to sign the commit using git commit -s. Once you amend the commit with your sign-off and force push, it should pass.

https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#sign-your-work

slonka commented 1 year ago

The sign off is missing and the change is not that critical to the understanding of the docs, closing for now, if the author wants to re-open with the sign off we will accept it.