Closed miraage closed 10 years ago
Thanks, You are right, fixed on this commit https://github.com/kupriyanenko/jbone/commit/d17ed482e177fddf9f795c3e5643d7be11f93481
Also this strong type check can be replaced in other places. Just need to walk over code and look where replacement may be performed.
// upd.
I think the better idea is to check arguments.length, like
if (!arguments.length) { // or maybe 1 for methods like $.css('borderTop')
// getter
} else {
// setter
}
yes, I think in this case you are right.
You are checking value to being passed as string, but I think integer could be passed too. For example, method
val()
. https://github.com/kupriyanenko/jbone/blob/master/src/attributes.js#L22