kupriyanenko / jbone

JavaScript Library for Events and DOM manipulation. Replaces jQuery for Backbone (2.5kb gzipped)
http://jbone.js.org
MIT License
279 stars 35 forks source link

Add method is returning native array / breaks traversing #43

Closed henryruhs closed 9 years ago

henryruhs commented 9 years ago

I just updated to the latest jBone release and removed my jbone-extend micro lib, then I run to a bunch of errors in my testing suite.

First testing:

$('<div>').add('<span>');

Actual:: Array[div, span] Expected: Object[div, span]

Second testing:

$('<div>').add('<span>').addClass('test');

Actual:: addClass is not a function Expected: Object[div.test, span.test]

PS: I suggest to add a global integration test that is using all methods inside fn. and tests the traversing for each of them.

BTW: You are using "semantic versioning" in a wrong way, if you added new features you have to bump the minor and not the patch number... :-)

kupriyanenko commented 9 years ago

@redaxmedia got it, need to fix.

kupriyanenko commented 9 years ago
henryruhs commented 9 years ago

Great!

kupriyanenko commented 9 years ago

Released in 1.0.24